Add ignore_comments param to MaxLineLength check#1252
Open
Nezteb wants to merge 1 commit intorrrene:masterfrom
Open
Add ignore_comments param to MaxLineLength check#1252Nezteb wants to merge 1 commit intorrrene:masterfrom
ignore_comments param to MaxLineLength check#1252Nezteb wants to merge 1 commit intorrrene:masterfrom
Conversation
Owner
|
Hi, sorry for the delay. I will include this in Credo 1.8, just need a weekend or two more to get things into RC territory 👍 On a side note, I want to say that this check is becoming the most configurable (is that a word?) while it should be obsolete when using the formatter, which is kind of ironic 👀 |
Contributor
Author
No rush at all! 🙏
Yeah some folks I've talked to prefer to disable this check altogether because of how Elixir's formatter treats line length config:
Still, I opted for adding a configuration option. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long story short, a lot of projects I work with sometimes have very long comment lines and I want to ignore them in a opt-in fashion for this Credo check. 🙏