Skip to content

Add ignore_comments param to MaxLineLength check#1252

Open
Nezteb wants to merge 1 commit intorrrene:masterfrom
Nezteb:line-length-ignore-comments
Open

Add ignore_comments param to MaxLineLength check#1252
Nezteb wants to merge 1 commit intorrrene:masterfrom
Nezteb:line-length-ignore-comments

Conversation

@Nezteb
Copy link
Copy Markdown
Contributor

@Nezteb Nezteb commented Jan 29, 2026

Long story short, a lot of projects I work with sometimes have very long comment lines and I want to ignore them in a opt-in fashion for this Credo check. 🙏

@rrrene
Copy link
Copy Markdown
Owner

rrrene commented Feb 5, 2026

Hi, sorry for the delay.

I will include this in Credo 1.8, just need a weekend or two more to get things into RC territory 👍

On a side note, I want to say that this check is becoming the most configurable (is that a word?) while it should be obsolete when using the formatter, which is kind of ironic 👀

@Nezteb
Copy link
Copy Markdown
Contributor Author

Nezteb commented Feb 5, 2026

I will include this in Credo 1.8, just need a weekend or two more to get things into RC territory 👍

No rush at all! 🙏

I want to say that this check is becoming the most configurable (is that a word?) while it should be obsolete when using the formatter

Yeah some folks I've talked to prefer to disable this check altogether because of how Elixir's formatter treats line length config:

Still, I opted for adding a configuration option. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants