Open
Conversation
This complements the existing `Credo.Check.Warning.ForbiddenModule`. In our codebase, there are a number of specific functions from otherwise mundane modules that we'd like to forbid. For instance, `:erlang.binary_to_term/{1,2}` is one we found being used in a surprisingly (scarily) large number of places.
This functionality could potentially be included as an expansion of `ForbiddenModule`, but it would actually make more sense to me to go the other way and allow ForbiddenFunction to be configured to warn on all functions in a given module.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,96 @@ | |||
| defmodule Credo.Check.Warning.ForbiddenFunction do | |||
Check warning
Code scanning / Credo
Modules should have a @moduledoc tag. Warning
Owner
|
I like this, just need a bit of time to merge/integrate it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements the existing
Credo.Check.Warning.ForbiddenModule. In our codebase, there are a number of specific functions from otherwise mundane modules that we'd like to forbid. For instance,:erlang.binary_to_term/{1,2}is one we found being used in a surprisingly (scarily) large number of places.This functionality could potentially be included as an expansion of
ForbiddenModule, but it would actually make more sense to me to go the other way and allow ForbiddenFunction to be configured to warn on all functions in a given module. Not sure if that's worth the churn, though.