Skip to content

fix: patch chrome.runtime in place to preserve native bindings #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamEvanYT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: patch chrome.runtime in place to preserve native bindings #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions packages/electron-chrome-extensions/src/renderer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,12 @@ export const injectExtensionAPIs = () => {
}
}

const patchApiObject = <T extends object>(target: T | undefined, patch: object) => {
const api = (target || {}) as T
Object.defineProperties(api, Object.getOwnPropertyDescriptors(patch))
return api
}

const browserActionFactory = (base: DeepPartial<typeof globalThis.chrome.browserAction>) => {
const api = {
...base,
Expand Down Expand Up @@ -502,8 +508,7 @@ export const injectExtensionAPIs = () => {

runtime: {
factory: (base) => {
return {
...base,
return patchApiObject(base, {
connectNative: (application: string) => {
const port = new NativePort()
const receive = port._receive.bind(port)
Expand All @@ -516,7 +521,7 @@ export const injectExtensionAPIs = () => {
},
openOptionsPage: invokeExtension('runtime.openOptionsPage'),
sendNativeMessage: invokeExtension('runtime.sendNativeMessage'),
}
})
},
},

Expand Down Expand Up @@ -646,13 +651,18 @@ export const injectExtensionAPIs = () => {
Object.keys(apiDefinitions).forEach((key: any) => {
const apiName: keyof typeof chrome = key
const baseApi = chrome[apiName] as any
const api = apiDefinitions[apiName]!
const definition = apiDefinitions[apiName]!

// Allow APIs to opt-out of being available in this context.
if (api.shouldInject && !api.shouldInject()) return
if (definition.shouldInject && !definition.shouldInject()) return

const injectedApi = definition.factory(baseApi)

// Factories can patch native-backed APIs in place to preserve identity.
if (baseApi && injectedApi === baseApi) return

Object.defineProperty(chrome, apiName, {
value: api.factory(baseApi),
value: injectedApi,
enumerable: true,
configurable: true,
})
Expand Down
Loading