Don't pop outermost region when skipping#25738
Open
som-snytt wants to merge 1 commit intoscala:mainfrom
Open
Conversation
Contributor
Author
|
2nd try after #25712 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25683
When skipping on error, tokens are consumed and current region is adjusted. But don't blow past the outermost region. There is an existing guard for RBRACE.
On outdent, skip will drop until indented. Normally, on subsequent outdent, one expects a corresponding indent region, but that may have been stripped on error recovery.
How much have you relied on LLM-based tools in this contribution?
I forgot to again.
How was the solution tested?
After diagnosis, simplified the ticket example. Recovery from the first error sets up the crash.
Additional notes
I always wondered how regions worked.