Skip to content

fix(client_lib): force-derive thumbnail filename via timestamp #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkaczman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client_lib): force-derive thumbnail filename via timestamp #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client_lib/src/video.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ pub fn decrypt_thumbnail_file(
}
}

let dec_filename: String = thumbnail_meta_info.filename;
// Do not trust the sender-provided filename here.
// The timestamp is the stable identifier for thumbnails, and deriving the path from it prevents path traversal through attacker-crafted metadata.
let dec_filename = ThumbnailMetaInfo::get_filename_from_timestamp(thumbnail_meta_info.timestamp);
let dec_pathname: String = format!("{}/videos/{}", file_dir, dec_filename);

if Path::new(&dec_pathname).exists() {
Expand Down
Loading