Merged
Conversation
The ARP UninstallString now points to the app launcher with --jdeploy:uninstall --jdeploy:interactive=false instead of copying the installer exe to an uninstallers directory. The Go launcher handles uninstall natively via the uninstall manifest without requiring a JVM. - Remove installer exe copy to ~/.jdeploy/uninstallers/ during install - Point UninstallString at app launcher with --jdeploy:uninstall flag - Add QuietUninstallString for silent uninstall support
Smoke test now verifies app launcher and uninstall manifest exist instead of checking for the removed uninstallers directory. Uninstall test uses the app launcher with --jdeploy:uninstall flag.
The Go launcher schedules self-deletion via PowerShell with a 2-second delay. Poll up to 10 seconds for the app directory to be removed before failing the smoke test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.