Open
Conversation
added 5 commits
January 19, 2023 18:50
…espect user-defined sizes even if they are larger than the page.
added 2 commits
February 25, 2023 15:32
# Conflicts: # DocX/DocXWriting.swift # DocXTests/DocXTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements image autosizing if a custom page size is defined and the image is larger than the printable area of the page. In this case, the image is shrunk to fit the printable area.
Issues with the current implementation:
NSTextAttachement(NSTextAttachement.bounds) is overridden if it is larger than th printable area. This might be surprising.lenna.png, 512x512 pixel) in Word is only half the expected size when inserted via copy / paste into Word or if automatic sizing (no page size or bounds defined inDocX) are used. It is not entirely clear when default values Word is using for autosizing.