Skip to content

feat(workflow): resolve canvas re-rendering and logs perf issues #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adithyaakrishna wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

feat(workflow): resolve canvas re-rendering and logs perf issues #3844

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f225168
chore: fix conflicts
adithyaakrishna Mar 30, 2026
898428d
chore: fix rerenders
adithyaakrishna Mar 30, 2026
4afba1c
chore: fix review changes
adithyaakrishna Mar 30, 2026
2831432
chore: fix review changes
adithyaakrishna Mar 30, 2026
d37302a
chore: fix review changes
adithyaakrishna Mar 30, 2026
0ec73b0
chore: fix review changes
adithyaakrishna Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/sim/app/(landing)/partners/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { Metadata } from 'next'
import Link from 'next/link'
import { getNavBlogPosts } from '@/lib/blog/registry'
import { martianMono } from '@/app/_styles/fonts/martian-mono/martian-mono'
import { season } from '@/app/_styles/fonts/season/season'
Expand Down
15 changes: 14 additions & 1 deletion ...[workflowId]/components/terminal/components/output-panel/components/structured-output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,11 +711,24 @@ export const StructuredOutput = memo(function StructuredOutput({
}, [])

// Reset expanded paths when data changes
const prevDataJsonRef = useRef<string>('')

useEffect(() => {
if (prevDataRef.current !== data || prevIsErrorRef.current !== isError) {
if (prevIsErrorRef.current !== isError) {
prevDataRef.current = data
prevIsErrorRef.current = isError
prevDataJsonRef.current = JSON.stringify(data)
setExpandedPaths(computeInitialPaths(data, isError))
return
}

if (prevDataRef.current !== data) {
const newJson = JSON.stringify(data)
if (prevDataJsonRef.current !== newJson) {
prevDataJsonRef.current = newJson
setExpandedPaths(computeInitialPaths(data, isError))
}
Copy link
Copy Markdown

@cursor cursor bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unguarded JSON.stringify can throw on non-serializable data

Medium Severity

The new deep-equality check calls JSON.stringify(data) without a try-catch. If data contains circular references, BigInt values, or other non-JSON-serializable structures, this will throw an unhandled error and crash the structured output component. The previous code only compared by reference (prevDataRef.current !== data), which can never throw.

Additional Locations (1)
Fix in Cursor Fix in Web

prevDataRef.current = data
}
}, [data, isError])

Expand Down
Loading
Loading