fix: add scheme support, centralize BaseURL, fix response body leak#8
Draft
LaurenDebruyn wants to merge 1 commit intomainfrom
Draft
fix: add scheme support, centralize BaseURL, fix response body leak#8LaurenDebruyn wants to merge 1 commit intomainfrom
LaurenDebruyn wants to merge 1 commit intomainfrom
Conversation
Add --scheme flag to auth login so users can connect over HTTP for local dev. Centralize host+scheme defaulting in Profile.BaseURL() and use it everywhere (API client, auth status, login confirmation). Fix response body leak in UpdateMetricMonitoring by decoding the POST response. Remove redundant UpdateMetricMonitoringRequest struct in favor of MetricMonitoringSettings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--schemeflag toauth loginfor HTTP connections (e.g. local dev)Profile.BaseURL()— used by API client,auth status, and login confirmationUpdateMetricMonitoringby properly decoding the POST responseUpdateMetricMonitoringRequeststruct, useMetricMonitoringSettingsdirectlyTest plan
sodacli auth login --scheme http --host localhost:8080 --api-key-id x --api-key-secret yconnects over HTTPsodacli auth statusdisplays full URL including scheme when non-defaultsodacli monitor config <dataset-id> --enablestill works (uses updatedMetricMonitoringSettingstype)🤖 Generated with Claude Code