fix: Correct PostgreSQL connection pool parameter name and defaults#1516
Open
claudespice wants to merge 1 commit intotrunkfrom
Open
fix: Correct PostgreSQL connection pool parameter name and defaults#1516claudespice wants to merge 1 commit intotrunkfrom
claudespice wants to merge 1 commit intotrunkfrom
Conversation
The PostgreSQL data accelerator docs used the non-existent parameter name `pg_connection_pool_min` (default `5`) instead of the actual parameter `pg_connection_pool_min_idle` (default `1`). The `connection_pool_size` default was also incorrectly documented as `10` instead of `5` — the default changed from 10 to 5 in v1.8.0 (spiceai/spiceai#7403) but the docs were never updated. Fixes across vNext and versioned docs (1.8.x through 1.11.x): - Rename `pg_connection_pool_min` to `pg_connection_pool_min_idle` - Correct default from `5` to `1` for `pg_connection_pool_min_idle` - Correct default from `10` to `5` for `connection_pool_size` - Add missing `pg_connection_pool_min_idle` to data connector docs for versions 1.8.x through 1.11.x Verified against spiceai/spiceai at trunk, v1.11.5, v1.10.4, v1.9.2, and v1.8.0 — all have `.default("1")` for `connection_pool_min_idle` and `.default("5")` for `connection_pool_size`.
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://3f91f1e4.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_connection_pool_min(default5) instead of the actual parameterpg_connection_pool_min_idle(default1)connection_pool_sizedefault was documented as10but the code default changed to5in v1.8.0 (Make database connection pool sizes consistent spiceai#7403)pg_connection_pool_min_idleparameter was missing from the data connector docs for versions 1.8.x through 1.11.xChanges
pg_connection_pool_min→pg_connection_pool_min_idlein all data accelerator docs (vNext + 1.8.x–1.11.x)pg_connection_pool_min_idledefault from5→1connection_pool_sizedefault from10→5in data accelerator and data connector docs (1.8.x–1.10.x)pg_connection_pool_min_idleparameter to data connector docs (1.8.x–1.11.x)Reference
Verified against
spiceai/spiceaiat trunk, v1.11.5, v1.10.4, v1.9.2, and v1.8.0 —crates/data-connectors/connector-postgres/src/lib.rsdefinesconnection_pool_min_idlewith.default("1")andconnection_pool_sizewith.default("5").