fix: Document missing snapshot acceleration parameters#1517
Merged
Conversation
Add documentation for two undocumented acceleration snapshot parameters that were introduced in v1.11.0: - `acceleration.snapshots_creation_policy` (default: `on_change`) — controls whether snapshots are created after every refresh or only when data changes - `acceleration.snapshots_reset_expiry_on_load` (default: `disabled`) — controls whether snapshot expiry is reset when loading during bootstrap Added to vNext and v1.11.x reference docs. Verified against spiceai/spiceai at trunk and v1.11.5 — crates/spicepod/src/acceleration/mod.rs defines both parameters.
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://2935855d.spiceai-org-website.pages.dev |
lukekim
approved these changes
Apr 16, 2026
|
🚀 deployed to https://e93418d6.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceleration.snapshots_creation_policy— controls whether snapshots are created after every refresh (always) or only when data changes (on_change, default)acceleration.snapshots_reset_expiry_on_load— controls whether snapshot expiry is reset when loading during bootstrap (disableddefault,enabled)Changes
Reference
Verified against
spiceai/spiceaiat trunk and v1.11.5 —crates/spicepod/src/acceleration/mod.rsdefines both enums with their defaults.