Fix tracing observation handlers not registered due to auto-configuration ordering#5756
Open
JadenKim-dev wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
…tion ordering Add afterName ordering constraint to ensure Spring AI observation auto-configurations run after MicrometerTracingAutoConfiguration. Without this ordering, @ConditionalOnBean(Tracer.class) is evaluated before BraveAutoConfiguration/OpenTelemetryAutoConfiguration creates the Tracer bean, causing both TracerPresent and TracerNotPresent configurations to be skipped. Closes spring-projects#5641 Signed-off-by: JadenKim-dev <jaden.kim5179@gmail.com>
JadenKim-dev
force-pushed
the
fix/5641-tracing-autoconfiguration-ordering
branch
from
cdfb2f1 to
f4f0570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5641
Spring AI observation auto-configurations use
@ConditionalOnBean(Tracer.class)to determine whether to register tracing-aware observation handlers. However, without explicit ordering constraints, these configurations can be processed beforeBraveAutoConfigurationorOpenTelemetryAutoConfigurationcreates theTracerbean.When this happens, both
TracerPresentObservationConfigurationandTracerNotPresentObservationConfigurationare skipped — no observation handlers are registered at all.Changes
Added
afterName = "...MicrometerTracingAutoConfiguration"to the following auto-configurations:ChatClientAutoConfigurationChatObservationAutoConfigurationImageObservationAutoConfigurationVectorStoreObservationAutoConfigurationMicrometerTracingAutoConfigurationis used rather than individual implementations (e.g.BraveAutoConfiguration) to cover both Brave and OpenTelemetry.