fix: Allow overriding the MCP endpoint for non-supported MediaTypes#5769
Open
nielsbasjes wants to merge 1 commit intospring-projects:mainfrom
Open
fix: Allow overriding the MCP endpoint for non-supported MediaTypes#5769nielsbasjes wants to merge 1 commit intospring-projects:mainfrom
nielsbasjes wants to merge 1 commit intospring-projects:mainfrom
Conversation
…like HTML). Signed-off-by: Niels Basjes <niels@basjes.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Routing to the mcp endpoint was hardcoded to route everything to the provided methods.
In the code of those methods then was checked if the right content-type could be provided for what the client could accept.
The effect is that implementing an HTML page to a user who accidentally opened the mcp endpoint was much harder than needed.
This change moves the accepted content type checks to the routing function and removes the needless GET handlers where GET is not implemented.
The advantage of this change is that now you can simply provide a meaningful explanation by simply implementing something like
@GetMapping(value = "/mcp", produces = MediaType.TEXT_HTML_VALUE)The downside of this change is that now doing a GET that is not allowed returns a 404 (Not Found) instead of the current 405 (Method Not Allowed).
I'm looking forward to your feedback on this proposal.