Skip to content

fix: close connection to avoid resource leak #36360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuiweixie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: close connection to avoid resource leak #36360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e39b74
fix: close connection to avoid resource leak
cuiweixie Feb 20, 2026
03ea4f0
fix: review
cuiweixie Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spring-core/src/main/java/org/springframework/core/io/AbstractFileResolvingResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ public boolean exists() {
httpCon.setRequestMethod("HEAD");
int code = httpCon.getResponseCode();
if (code == HttpURLConnection.HTTP_OK) {
httpCon.disconnect();
return true;
}
else if (code == HttpURLConnection.HTTP_NOT_FOUND) {
httpCon.disconnect();
return false;
}
else if (code == HttpURLConnection.HTTP_BAD_METHOD) {
Expand All @@ -74,9 +76,11 @@ else if (code == HttpURLConnection.HTTP_BAD_METHOD) {
if (con instanceof HttpURLConnection newHttpCon) {
code = newHttpCon.getResponseCode();
if (code == HttpURLConnection.HTTP_OK) {
newHttpCon.disconnect();
return true;
}
else if (code == HttpURLConnection.HTTP_NOT_FOUND) {
newHttpCon.disconnect();
return false;
}
httpCon = newHttpCon;
Expand Down