Skip to content

Update THV-0057 key format to prevent cross-type collisions #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerm-dro merged 1 commit into from
Apr 10, 2026
+5 −3
Merged

Update THV-0057 key format to prevent cross-type collisions #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rfcs/THV-0057-rate-limiting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,11 @@ Per-user limits work identically — each user gets their own bucket, keyed by i
- Global per-prompt: `thv:rl:{namespace}:{server}:global:prompt:{promptName}`
- Global per-resource: `thv:rl:{namespace}:{server}:global:resource:{resourceName}`
- Per-user: `thv:rl:{namespace}:{server}:user:{userId}`
- Per-user per-tool: `thv:rl:{namespace}:{server}:user:{userId}:tool:{toolName}`
- Per-user per-prompt: `thv:rl:{namespace}:{server}:user:{userId}:prompt:{promptName}`
- Per-user per-resource: `thv:rl:{namespace}:{server}:user:{userId}:resource:{resourceName}`
- Per-user per-tool: `thv:rl:{namespace}:{server}:user-tool:{toolName}:{userId}`
- Per-user per-prompt: `thv:rl:{namespace}:{server}:user-prompt:{promptName}:{userId}`
- Per-user per-resource: `thv:rl:{namespace}:{server}:user-resource:{resourceName}:{userId}`

Per-user per-operation keys use distinct prefixes (`user-tool:`, `user-prompt:`, `user-resource:`) rather than nesting under `user:{userId}:tool:...` to prevent key collisions when a `userId` contains delimiter characters (e.g., `:tool:`). The operation name precedes the userId so that the variable-length userId is always the terminal component.

The `{namespace}` and `{server}` components are derived from the CRD metadata at middleware initialization time, never from per-request input.

Expand Down