refactor: rename McpPort to MCPPort for Go naming conventions#4589
refactor: rename McpPort to MCPPort for Go naming conventions#4589mvanhorn wants to merge 3 commits intostacklok:mainfrom
Conversation
mvanhorn
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
yrobla
as code owners
|
@mvanhorn You have an out of date branch/merge conflicts |
mvanhorn
force-pushed
the
osc/4582-mcpport-naming
branch
from
91bcb14 to
9642bfc
Compare
|
Rebased onto current main in 9642bfc. Also caught 3 additional files that upstream changed since the original PR - applied the McpPort -> MCPPort rename to those as well (integration and scaling tests). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
+ Coverage 68.71% 68.73% +0.02%
==========================================
Files 517 517
Lines 54817 54817
==========================================
+ Hits 37666 37680 +14
+ Misses 14252 14242 -10
+ Partials 2899 2895 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mvanhorn there's some CRD steps you need to do. some |
|
Ran |
github-actions
bot
added
size/XS
|
@mvanhorn ahhh almost there, we got some lint checks now |
Rename the Go struct field McpPort to MCPPort and the method GetMcpPort to GetMCPPort to follow Go convention of all-caps acronyms. JSON tag remains mcpPort (no wire-format change). Closes stacklok#4582
Run `task operator-manifests` and `task crdref-gen` to update generated files with the McpPort -> MCPPort rename from the previous commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes lint failure by applying the MCPPort rename to mcpserver_scaling_test.go and ratelimit_test.go which were missed in the previous commits. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mvanhorn
force-pushed
the
osc/4582-mcpport-naming
branch
from
f258512 to
258eff8
Compare
|
Fixed - rebased and caught the remaining McpPort references in mcpserver_scaling_test.go and ratelimit_test.go (258eff8). Should clear the lint check now. |
github-actions
bot
added
size/XS
2 participants
Summary
McpPorttoMCPPortand methodGetMcpPorttoGetMCPPortacross 15 files to follow Go's all-caps acronym conventionmcpPortis unchanged, so no wire-format or API breaking changeTest plan
go build ./cmd/thv-operator/... ./pkg/export/... ./pkg/vmcp/...)Closes #4582