Add coding conventions derived from recent PR review feedback#4636
Open
Add coding conventions derived from recent PR review feedback#4636
Conversation
yrobla
requested review from
JAORMX,
jerm-dro,
jhrozek and
rdimitrov
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Claude rule docs to codify recurring review feedback (interface design, testing practices, operator status consistency, and PR hygiene) so those expectations are enforced consistently going forward.
Changes:
- Add new Go style guidance for interface design, URL validation, bounded caches, and concurrency comment accuracy.
- Expand testing rules with E2E expectations, discouraging test hooks in production structs, and requiring timeouts for blocking concurrency barriers.
- Add operator and PR-creation guidance around status condition parity and keeping PRs single-scope.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .claude/rules/vmcp-anti-patterns.md | Adds a new vMCP anti-pattern covering mutex-protected mutable domain objects. |
| .claude/rules/testing.md | Tightens test naming guidance and adds new sections for E2E behavior coverage and concurrency/testing patterns. |
| .claude/rules/pr-creation.md | Adds a “PR Scope” section to discourage mixed-scope PRs. |
| .claude/rules/operator.md | Adds guidance to keep status conditions consistent across parallel CRD types. |
| .claude/rules/go-style.md | Adds new Go conventions around interfaces, string constants, URL validation, bounded caches, and concurrency comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4636 +/- ##
==========================================
+ Coverage 68.85% 68.86% +0.01%
==========================================
Files 508 508
Lines 52604 52604
==========================================
+ Hits 36220 36227 +7
+ Misses 13586 13581 -5
+ Partials 2798 2796 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
638b7e0 to
089dae9
Compare
github-actions
bot
added
size/XS
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
089dae9 to
0cc2756
Compare
github-actions
bot
added
size/XS
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jerm-dro
reviewed
Apr 7, 2026
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
8f72233 to
9d94929
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
size/S
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
9d94929 to
11a8d8e
Compare
github-actions
bot
added
size/S
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
11a8d8e to
d4cf699
Compare
github-actions
bot
added
size/S
Captures patterns flagged in reviews across interface design, testing, operator development, and PR hygiene — so they apply automatically going forward rather than being caught in review.
yrobla
force-pushed
the
add-testing-rules-from-pr-4497
branch
from
d4cf699 to
41c82dc
Compare
github-actions
bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures patterns flagged in reviews across interface design, testing, operator development, and PR hygiene — so they apply automatically going forward rather than being caught in review.
Fixes #
Type of change
Test plan
task test)task test-e2e)task lint-fix)Changes
Does this introduce a user-facing change?
Special notes for reviewers