Rename MCPGroup Ready printcolumn to Checked#4655
Open
qorexdev wants to merge 2 commits intostacklok:mainfrom
Open
Rename MCPGroup Ready printcolumn to Checked#4655qorexdev wants to merge 2 commits intostacklok:mainfrom
qorexdev wants to merge 2 commits intostacklok:mainfrom
Conversation
the column was showing MCPServersChecked condition status, not a Ready condition. closes stacklok#4617
qorexdev
requested review from
ChrisJBurns,
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4655 +/- ##
==========================================
+ Coverage 68.84% 68.89% +0.05%
==========================================
Files 509 509
Lines 52668 52668
==========================================
+ Hits 36259 36287 +28
+ Misses 13606 13575 -31
- Partials 2803 2806 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The Go vulnerability check failures are pre-existing dep issues in the codebase - the scheduled security scan on main has been failing since Apr 8 with the same CVE IDs (GO-2026-4864, etc.) due to an updated govulncheck database. My change only touches YAML/Helm templates, no Go code. |
ChrisJBurns
approved these changes
Apr 8, 2026
github-actions
bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCPGroup CRD had a printer column labeled "Ready" but it was reading from the
MCPServersCheckedcondition — not a Ready condition. This is misleading since "Ready" has a specific meaning in Kubernetes conventions (overall operational health), whileMCPServersCheckedjust means the controller finished checking the referenced servers.Renames the column to "Checked" to match the actual condition it queries.
Fixes #4617
Type of change
Test plan
Verified the marker, generated CRD YAML, and Helm template all consistently show
name: Checkedpointing to theMCPServersCheckedcondition.