Skip to content

Revert "Add LRU capacity to ValidatingCache, remove sentinel pattern, add storage Update" #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yrobla merged 1 commit into from
Apr 10, 2026
+570 −768

Revert "Add LRU capacity to ValidatingCache, remove sentinel pattern,…

c9673d7
Select commit
Loading
Failed to load commit list.
Merged

Revert "Add LRU capacity to ValidatingCache, remove sentinel pattern, add storage Update" #4730

Revert "Add LRU capacity to ValidatingCache, remove sentinel pattern,…
c9673d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 10, 2026 in 0s

68.74% (+0.06%) compared to 9c974a3

View this Pull Request on Codecov

68.74% (+0.06%) compared to 9c974a3

Details

Codecov Report

❌ Patch coverage is 81.45161% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.74%. Comparing base (9c974a3) to head (c9673d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/vmcp/server/sessionmanager/session_manager.go 55.55% 12 Missing and 8 partials ⚠️
...kg/transport/session/session_data_storage_local.go 93.54% 1 Missing and 1 partial ⚠️
pkg/vmcp/server/sessionmanager/cache.go 97.82% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4730      +/-   ##
==========================================
+ Coverage   68.68%   68.74%   +0.06%     
==========================================
  Files         518      518              
  Lines       54826    54826              
==========================================
+ Hits        37657    37690      +33     
+ Misses      14274    14242      -32     
+ Partials     2895     2894       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov