feat: add stats/strided/dpcorrwd#10677
Open
nakul-krishnakumar wants to merge 5 commits intostdlib-js:developfrom
Open
feat: add stats/strided/dpcorrwd#10677nakul-krishnakumar wants to merge 5 commits intostdlib-js:developfrom
stats/strided/dpcorrwd#10677nakul-krishnakumar wants to merge 5 commits intostdlib-js:developfrom
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
lib/node_modules/@stdlib/stats/strided/dpcorrwd/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/strided/dpcorrwd/docs/types/test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
Member
Author
Member
|
/stdlib merge |
stdlib-bot
added
the
bot: In Progress
kgryte
added
Feature
kgryte
reviewed
Apr 12, 2026
| */ | ||
| interface Routine { | ||
| /** | ||
| * Computes the sample Pearson product-moment correlation coefficient of two double-precision floating-point strided arrays using Welford algorithm. |
Member
There was a problem hiding this comment.
Suggested change
| * Computes the sample Pearson product-moment correlation coefficient of two double-precision floating-point strided arrays using Welford algorithm. | |
| * Computes the sample Pearson product-moment correlation coefficient of two double-precision floating-point strided arrays using Welford's algorithm. |
This comment applies here and throughout this PR.
kgryte
reviewed
Apr 12, 2026
| * @param strideX - stride length of `x` | ||
| * @param y - second input array | ||
| * @param strideY - stride length of `y` | ||
| * @returns pearson correlation coefficient |
Member
There was a problem hiding this comment.
Suggested change
| * @returns pearson correlation coefficient | |
| * @returns Pearson correlation coefficient |
Pearson is capitalized as it is a proper noun. Applies here and throughout this PR.
kgryte
reviewed
Apr 12, 2026
Comment on lines
+51
to
+52
|
|
||
| The use of the term `n-1` is commonly referred to as Bessel's correction. Depending on the characteristics of the population distributions, other correction factors (e.g., `n-1.5`, `n+1`, etc) can yield better estimators. |
Member
There was a problem hiding this comment.
Suggested change
| The use of the term `n-1` is commonly referred to as Bessel's correction. Depending on the characteristics of the population distributions, other correction factors (e.g., `n-1.5`, `n+1`, etc) can yield better estimators. |
Member
There was a problem hiding this comment.
This note isn't really that useful here and not actionable.
kgryte
requested changes
Apr 12, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Other than the documentation nits, this is looking good.
kgryte
added
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None.
Description
This pull request:
stats/strided/dpcorrwd.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
None.
@stdlib-js/reviewers