Make:entity: Add question about unsigned integer#1661
Open
Menelion wants to merge 3 commits intosymfony:1.xfrom
Open
Make:entity: Add question about unsigned integer#1661Menelion wants to merge 3 commits intosymfony:1.xfrom
Menelion wants to merge 3 commits intosymfony:1.xfrom
Conversation
Author
|
There is an error in a test that I, it seems, didn't touch 😕 |
Author
|
Dear core contributors, is it OK to merge now? All checks passed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is my first contribution, so please bear with me.
So often, when adding entities, I wanted integers to be unsigned, so I decided to add this question if the field type is integer. Most probably did I miss something, so I'm all ears for your comments.