Allow creation of classes with the same name as PHP native classes#1676
Open
Fan2Shrek wants to merge 1 commit intosymfony:1.xfrom
Open
Allow creation of classes with the same name as PHP native classes#1676Fan2Shrek wants to merge 1 commit intosymfony:1.xfrom
Fan2Shrek wants to merge 1 commit intosymfony:1.xfrom
Conversation
Fan2Shrek
force-pushed
the
fix/creation-with-native-php-classname
branch
from
7bd0bd1 to
a571ae6
Compare
Fan2Shrek
force-pushed
the
fix/creation-with-native-php-classname
branch
from
a571ae6 to
bc92fb0
Compare
Contributor
Author
|
The test failures are related, but I'm not entirely sure how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1675
When trying to create a class with a native PHP name (e.g., Directory),
Validator::classDoesNotExistincorrectly throws an error stating that the class already exists. To fix this, we need to prepend the namespace before performing the check.