fix(fs): fix crash on getting file descriptor from android content uri#3236
Open
aiueo13 wants to merge 2 commits intotauri-apps:v2from
Open
fix(fs): fix crash on getting file descriptor from android content uri#3236aiueo13 wants to merge 2 commits intotauri-apps:v2from
aiueo13 wants to merge 2 commits intotauri-apps:v2from
Conversation
Contributor
Package Changes Through b710350There are 10 changes which include updater with minor, updater-js with minor, barcode-scanner with patch, barcode-scanner-js with patch, fs with patch, fs-js with patch, http with patch, http-js with patch, sql with patch, sql-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash that occurs when opening a file from an Android Content URI due to missing permissions or the file not existing.
Details
Before the fix, Kotlin’s getFileDescriptor function would return
nullwhen the file was unavailable.plugins-workspace/plugins/fs/android/src/main/java/FsPlugin.kt
Lines 63 to 67 in 69a9d57
However, on the Rust side that receives it,
nulltriggersunimplemented!(), causing a panic.plugins-workspace/plugins/fs/src/mobile.rs
Lines 86 to 93 in 69a9d57
And with this PR, the getFileDescriptor function will throw an error instead of returning null when the file is not available.