fix(opener): allow open network share locations#3343
fix(opener): allow open network share locations#3343Legend-Master wants to merge 8 commits intotauri-apps:v2from
Conversation
Package Changes Through 1281e0eThere are 16 changes which include sql with minor, sql-js with minor, deep-link with patch, deep-link-js with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, updater with patch, updater-js with patch, nfc with patch, nfc-js with patch, opener with patch, opener-js with patch, dialog with minor, dialog-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Don't really have time to work on this right now, will still need some unit tests |
|
Hey @Legend-Master After a really brief look I'm seeing three functions that could use some extra test coverage.
Potentially checking input such as |
|
That will be awesome! And yes, that's the type of unit tests I wanted to add |
|
To keep things neat, I've submitted the PR Legend-Master#1 to your working branch.. |
|
you forgot the changefile :) |
Closes #3304
Closes #3335
Mirror Byron/open-rs#117 but with the copied in
std::path::absoluteplus some tweaksAlso added support for revealing drives like
C:which fails withNoParentpreviously