Skip to content

fix(opener): allow open network share locations#3343

Open
Legend-Master wants to merge 8 commits intotauri-apps:v2from
Legend-Master:reveal-network-path
Open

fix(opener): allow open network share locations#3343
Legend-Master wants to merge 8 commits intotauri-apps:v2from
Legend-Master:reveal-network-path

Conversation

@Legend-Master
Copy link
Copy Markdown
Contributor

@Legend-Master Legend-Master commented Mar 11, 2026

Closes #3304
Closes #3335

Mirror Byron/open-rs#117 but with the copied in std::path::absolute plus some tweaks
Also added support for revealing drives like C: which fails with NoParent previously

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Package Changes Through 1281e0e

There are 16 changes which include sql with minor, sql-js with minor, deep-link with patch, deep-link-js with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, updater with patch, updater-js with patch, nfc with patch, nfc-js with patch, opener with patch, opener-js with patch, dialog with minor, dialog-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.41 2.0.42
api-example-js 2.0.37 2.0.38
deep-link-example-js 2.2.10 2.2.11
deep-link 2.4.7 2.4.8
deep-link-js 2.4.7 2.4.8
fs 2.4.5 2.5.0
fs-js 2.4.5 2.5.0
dialog 2.6.0 2.7.0
dialog-js 2.6.0 2.7.0
opener 2.5.3 2.5.4
opener-js 2.5.3 2.5.4
http 2.5.7 2.5.8
http-js 2.5.7 2.5.8
nfc 2.3.4 2.3.5
nfc-js 2.3.4 2.3.5
persisted-scope 2.3.5 2.3.6
single-instance 2.4.0 2.4.1
sql 2.3.2 2.4.0
sql-js 2.3.2 2.4.0
updater 2.10.0 2.10.1
updater-js 2.10.0 2.10.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Copy Markdown
Contributor Author

Don't really have time to work on this right now, will still need some unit tests

@markgandolfo
Copy link
Copy Markdown

Hey @Legend-Master
Do you have a view on what unit tests might be needed? I've just butted up against this problem and am happy to help get this PR across the line so it makes the next release.

After a really brief look I'm seeing three functions that could use some extra test coverage.

shell_parent_path() absolute() and absolute_and_check_exists()

Potentially checking input such as
C:\, \\server\share, C: \\wsl.localhost\Ubuntu, \\server\share\file.txt, etc.

@Legend-Master
Copy link
Copy Markdown
Contributor Author

That will be awesome! And yes, that's the type of unit tests I wanted to add

@markgandolfo
Copy link
Copy Markdown

To keep things neat, I've submitted the PR Legend-Master#1 to your working branch..

@Legend-Master Legend-Master marked this pull request as ready for review April 3, 2026 04:02
@Legend-Master Legend-Master requested a review from a team as a code owner April 3, 2026 04:02
@FabianLars
Copy link
Copy Markdown
Member

you forgot the changefile :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tauri-plugin-opener bug - revealItemInDir fails for UNC network paths on Windows

3 participants