Skip to content

fix(barcode-scanner): resolve scan() after cleanup in windowed mode on iOS #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afadil wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

fix(barcode-scanner): resolve scan() after cleanup in windowed mode on iOS #3349

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d06f0ac
fix(barcode-scanner): delay destroy() after resolve() in windowed mod…
afadil Mar 15, 2026
84dd8ec
fix: guard against duplicate resolve during destroy delay
afadil Mar 15, 2026
044e2c3
fix(barcode-scanner): resolve scan() after cleanup in windowed mode o…
afadil Mar 15, 2026
e8cde46
Merge branch 'v2' into fix/barcode-scanner-windowed-ios-resolve
afadil Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion plugins/barcode-scanner/ios/Sources/BarcodeScannerPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,19 @@ class BarcodeScannerPlugin: Plugin, AVCaptureMetadataOutputObjectsDelegate {
jsObject["content"] = found.stringValue
}

// Stop scanning and clean up camera and webview state before
// resolving. In windowed mode, restoring webView.isOpaque after
// resolve() prevents the IPC response from reaching JavaScript.
self.isScanning = false
dismantleCamera()
if windowed {
let backgroundColor = previousBackgroundColor ?? UIColor.white
webView.isOpaque = true
webView.backgroundColor = backgroundColor
webView.scrollView.backgroundColor = backgroundColor
}
invoke?.resolve(jsObject)
destroy()
invoke = nil

}
}
Expand Down