Skip to content

add updaterJsonUseApiUrl parameter #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matias-albacore wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

add updaterJsonUseApiUrl parameter #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cbc614
feat: add updaterJsonUseApiUrl parameter
matias-albacore Mar 24, 2026
77bf72f
chore: rebuild
matias-albacore Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ inputs:
updaterJsonPreferNsis:
description: 'Whether the action will use the NSIS (setup.exe) or WiX (.msi) bundles for the updater JSON if both types exist. Will default to false. May default to true for apps using tauri@v2 in the future.'
default: 'false'
updaterJsonUseApiUrl:
description: 'Whether the updater JSON should use GitHub API download URLs (https://api.github.com/repos/OWNER/REPO/releases/assets/ASSET_ID) instead of browser download URLs. Useful for private repos where browser download URLs require authentication.'
default: 'false'
tauriScript:
description: 'The script to run to build the Tauri app'
args:
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/inputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ export const updaterJsonPreferNsis = core.getBooleanInput(
'updaterJsonPreferNsis',
);

export const updaterJsonUseApiUrl = core.getBooleanInput(
'updaterJsonUseApiUrl',
);

export const isAndroid = core.getInput('mobile').toLowerCase() === 'android';
export const isIOS = core.getInput('mobile').toLowerCase() === 'ios';
export const isDebug = parsedArgs.debug as boolean;
22 changes: 14 additions & 8 deletions src/upload-version-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
releaseAssetNamePattern,
repo,
updaterJsonPreferNsis,
updaterJsonUseApiUrl,
} from './inputs';
import { uploadAssets } from './upload-release-assets';
import {
Expand Down Expand Up @@ -124,7 +125,9 @@ export async function uploadVersionJSON(
downloadUrls.push({
name: data.name,
label: data.label,
url: data.browser_download_url,
url: updaterJsonUseApiUrl
? `${githubBaseUrl}/repos/${owner}/${repo}/releases/assets/${data.id}`
: data.browser_download_url,
});
}

Expand Down Expand Up @@ -233,13 +236,16 @@ export async function uploadVersionJSON(
continue;
}

// Untagged release downloads won't work after the release was published
updaterFileDownloadUrl = updaterFileDownloadUrl.replace(
/\/download\/(untagged-[^/]+)\//,
tagName
? `/download/${encodeURIComponent(tagName)}/`
: '/latest/download/',
);
// Untagged release downloads won't work after the release was published.
// API URLs don't need this transformation.
if (!updaterJsonUseApiUrl) {
updaterFileDownloadUrl = updaterFileDownloadUrl.replace(
/\/download\/(untagged-[^/]+)\//,
tagName
? `/download/${encodeURIComponent(tagName)}/`
: '/latest/download/',
);
}

let os = targetInfo.platform as string;
if (os === 'macos') {
Expand Down