Conversation
|
Time Zone Canonicalization shouldn't be deleted as far as I'm aware. We adopted most of its text into Temporal but it still has text that needs to go into ECMA-402 when reaching stage 4. cc @justingrant in case I'm wrong |
ljharb
left a comment
There was a problem hiding this comment.
there's a lot going on in this commit, and not all of it is correct.
immutable arraybuffers remain at stage 2.7; Time Zone Canonicalization shouldn't be removed afaict.
i'll rebase to fix these and to split the changes up into smaller commits. thanks for catching the JSON.parse source text omission!
|
i was going off of the message here which seems pretty unambiguous, but definitely happy to revise if i'm wrong! |
|
aha, good point on that one, thanks :-) i'll account for it. |
|
as for immutable array buffers i see i missed the conditional-ness. sorry about that! |
f0b2263 to
422c7cc
Compare
|
I wasn't aware @jridgewell was no longer championing "destructuring private fields"; it'd be great to confirm that. The others I'm aware of. |
that is based on what he said at the last stage 2 proposal review:
|
thanks for putting immutable array buffers back, but i also updated the last-presented and added a link to the test plan, do you mind preserving those edits? |
Oh yeah then I might be misremembering. |
422c7cc to
778ad02
Compare
|
Y'all move fast! Sorry I wasn't able to comment before this was merged.
Yep, the Time Zone Canonicalization proposal was merged into Temporal and no longer exists independently. Its repo will still be available, right? I wouldn't want links to its content to be broken. Also, should we put a link to the Time Zone Canonicalization proposal on the Inactive Proposals page? It's still valid content and history, even though it's been merged, so I wouldn't want it to be completely undiscoverable. Also, @ptomato did we also retire the Test262 tags for that proposal? If not then we shouldn't delete the lines at the end of this PR that remove those tags. |
|
Yep, the repo should be archived, but must be available forever. Yes, that's a great idea - a PR to the inactive proposals doc would be appreciated. |
|
@ljharb What abuot the other proposals changed by this PR? Don't they also belong in inactive proposals? |
|
No, all of the others remain active. |
|
cleanup the proposals page: