fix: remove YAML document separator from .tekton files#3342
Open
vdemeester wants to merge 1 commit intotektoncd:mainfrom
Open
fix: remove YAML document separator from .tekton files#3342vdemeester wants to merge 1 commit intotektoncd:mainfrom
vdemeester wants to merge 1 commit intotektoncd:mainfrom
Conversation
The '---' separator before the PipelineRun creates a multi-document YAML where the first document is comments-only. PAC tries to parse each document and fails with 'Object Kind is missing' on the empty first document. Removing the separator makes the comments part of the same YAML document as the PipelineRun, which PAC can parse correctly.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
do-not-merge/release-note-label-needed
tekton-robot
added
release-note-none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the
---YAML document separator between the license/description comments and the PipelineRun manifest in.tekton/release.yamland.tekton/release-patch.yaml.The
---creates a multi-document YAML file where the first document contains only comments (no Kubernetes object). PAC tries to parse each YAML document and logs an error for the empty one:This does not block incoming webhooks or release automation (PAC matches by PipelineRun name for those), but it generates noisy error logs on every GitHub event (PRs, pushes, comments, label changes) hitting the operator Repository CR.
Removing the
---makes the comments part of the same YAML document as the PipelineRun, eliminating the spurious parse errors.Submitter Checklist
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
/kind bug