Add typescript loader to foreman#13080
Add typescript loader to foreman#13080nadjaheitmann wants to merge 2 commits intotheforeman:rpm/developfrom
Conversation
53edefc to
bd516c8
Compare
346cfd5 to
71f93ea
Compare
71f93ea to
22e27b5
Compare
|
@theforeman/packaging Can we get a review here, please? |
| %{?scl:%scl_package nodejs-%{npm_name}} | ||
| %{!?scl:%global pkg_name %{name}} |
There was a problem hiding this comment.
This was generated by one of the templates, right? SCLs are a thing of the distant past :/
There was a problem hiding this comment.
I know, all of the npm package spec files look like this 🙈 The spec file was generated with this script: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/add_npm_package.sh
I assume it is this line and npm2rpm tool that also generates the spec file: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/add_npm_package.sh#L60
I have locally checked out the tool and ran the script. There is even --scl' option for npm2rpm if I see it correctly: https://github.com/theforeman/npm2rpm/blob/2acb4a459a75a36197cc13886d7aa08b9cf83302/bin/npm2rpm.js#L28
But this option is not set in the script.
There was a problem hiding this comment.
This was generated by one of the templates, right? SCLs are a thing of the distant past :/
22e27b5 to
6a64a4c
Compare
6a64a4c to
d8876a8
Compare
https://github.com/ATIX-AG/foreman_ansible_director
This plugin add a novelty in Foreman development which is using Typescript for the front end. For this to work, we need to package some additional typescript-related packages.
The related Foreman PR can be found here:
theforeman/foreman#10899
Summary (from RFC):
The related discourse RFC:
https://community.theforeman.org/t/rfc-opt-in-typescript-support-for-the-foreman-frontend-stack/45928