Skip to content

Add typescript loader to foreman#13080

Open
nadjaheitmann wants to merge 2 commits intotheforeman:rpm/developfrom
ATIX-AG:add_typescript_loader_to_foreman
Open

Add typescript loader to foreman#13080
nadjaheitmann wants to merge 2 commits intotheforeman:rpm/developfrom
ATIX-AG:add_typescript_loader_to_foreman

Conversation

@nadjaheitmann
Copy link
Copy Markdown

@nadjaheitmann nadjaheitmann commented Feb 20, 2026

https://github.com/ATIX-AG/foreman_ansible_director

This plugin add a novelty in Foreman development which is using Typescript for the front end. For this to work, we need to package some additional typescript-related packages.

The related Foreman PR can be found here:
theforeman/foreman#10899

Summary (from RFC):

  • Integration into Foreman nightly was done in less than 100 line diff due to Webpack already providing a very wrong base.
  • Usage of TypeScript remains optional
  • There are no changes required to the way Foreman packages are built and delivered.
  • No existing workflow or plugins are broken

The related discourse RFC:
https://community.theforeman.org/t/rfc-opt-in-typescript-support-for-the-foreman-frontend-stack/45928

@nadjaheitmann nadjaheitmann requested a review from a team as a code owner February 20, 2026 11:16
@nadjaheitmann nadjaheitmann marked this pull request as draft February 20, 2026 11:16
@nadjaheitmann nadjaheitmann force-pushed the add_typescript_loader_to_foreman branch from 53edefc to bd516c8 Compare February 20, 2026 11:57
@nadjaheitmann nadjaheitmann force-pushed the add_typescript_loader_to_foreman branch 2 times, most recently from 346cfd5 to 71f93ea Compare March 4, 2026 08:39
@nadjaheitmann nadjaheitmann marked this pull request as ready for review March 4, 2026 09:44
@nadjaheitmann nadjaheitmann force-pushed the add_typescript_loader_to_foreman branch from 71f93ea to 22e27b5 Compare March 16, 2026 07:15
@nadjaheitmann
Copy link
Copy Markdown
Author

@theforeman/packaging Can we get a review here, please?

Comment on lines +1 to +2
%{?scl:%scl_package nodejs-%{npm_name}}
%{!?scl:%global pkg_name %{name}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by one of the templates, right? SCLs are a thing of the distant past :/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, all of the npm package spec files look like this 🙈 The spec file was generated with this script: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/add_npm_package.sh

I assume it is this line and npm2rpm tool that also generates the spec file: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/add_npm_package.sh#L60

I have locally checked out the tool and ran the script. There is even --scl' option for npm2rpm if I see it correctly: https://github.com/theforeman/npm2rpm/blob/2acb4a459a75a36197cc13886d7aa08b9cf83302/bin/npm2rpm.js#L28

But this option is not set in the script.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by one of the templates, right? SCLs are a thing of the distant past :/

theforeman/npm2rpm#87

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my PR using @ekohls PR.

@nadjaheitmann nadjaheitmann force-pushed the add_typescript_loader_to_foreman branch from 22e27b5 to 6a64a4c Compare March 23, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants