Open
Conversation
Duologic
suggested changes
Sep 9, 2019
Contributor
Duologic
left a comment
Duologic
left a comment
There was a problem hiding this comment.
Maybe put it in modules/gce_net_services/?
Duologic
suggested changes
Sep 9, 2019
Duologic
suggested changes
Sep 11, 2019
| project = "${module.project.project_id}" | ||
| project = "${module.project.project_id}" | ||
| cert_manager_enabled = 1 | ||
| cert_manager_source_tags = "${var.node_pool_tags}" |
Contributor
There was a problem hiding this comment.
See line 27 in this file, we should set the node_pool_tags on kubernetes_cluster dynamically too.
| project = "${module.project.project_id}" | ||
| project = "${module.project.project_id}" | ||
| cert_manager_enabled = 1 | ||
| cert_manager_source_tags = "${var.node_pool_tags}" |
Contributor
There was a problem hiding this comment.
See line 27 in this file, we should set the node_pool_tags on kubernetes_cluster dynamically too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR is trying to fix?
Configure an additional firewall rule to allow the GKE control plane access to your webhook pod.
More info:
https://docs.cert-manager.io/en/latest/getting-started/webhook.html#running-on-private-gke-clusters
What approach did you choose and why?
Add service cert-manager
How can you test this?
Reproduce: Without rule by typing
kubectl api-resourcesapi returnsto apply rule
make plan && make applyand verifykubectl api-resourcesWhat feedback would you like, if any?
Welcome