Skip to content

Loosen the version of @types/node#87

Open
remcohaszing wants to merge 1 commit intomainfrom
loosen-node-types
Open

Loosen the version of @types/node#87
remcohaszing wants to merge 1 commit intomainfrom
loosen-node-types

Conversation

@remcohaszing
Copy link
Copy Markdown
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

@types/node is a bit different from other type definitions. Most type definitions from DefinitelyTyped define module type mirroring the public package structure. If two versions are installed, they both define types for a different version of the package.

@types/node however, declares modules other than node. These module definitions may clash. Also unified-engine doesn’t have a dependency on Node.js 22, it has a dependency on Node.js builtins that are available between Node.js 16 and the current latest version.

Packages solve this by specifying the @types/node dependency range as *. The only one that stands out in many cases is unified-engine.

`@types/node` is a bit different from other type definitions. Most type
definitions from DefinitelyTyped define module type mirroring the public
package structure. If two versions are installed, they both define types
for a different version of the package.

`@types/node` however, declares modules other than `node`. These module
definitions may clash. Also `unified-engine` doesn’t have a dependency
on Node.js 22, it has a dependency on Node.js builtins that are
available between Node.js 16 and the current latest version.

Packages solve this by specifying the `@types/node` dependency range as
`*`. The only one that stands out in many cases is `unified-engine`.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6f35eae) to head (f36f119).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         3214      3214           
=========================================
  Hits          3214      3214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤞 phase/open Post is being triaged manually

Development

Successfully merging this pull request may close these issues.

2 participants