Open
Conversation
Fixed hard gauge's behavior to accurately reflect how LR2 behaves by adding additional checks for when the gauge goes below 32 and if the total is at a certain value. The changes made are based on exch-bms2/beatoraja#628
|
I'm not sure if the edge case for gauge<=32 you implemented is correct, as it was already in the GaugeIncrementsAsm.h file. So effectively now drain reduction is calculated twice and the end result is wrong. Not sure about total, i would have to test that, but in current form its based off of LR2 code and is correct according to my testing. The issue with total was that some charts have total value overrode, instead of calculated value its dictated by .bms file explicitly. It's only present for hard gauge because for other gauges the code gets total value from game memory, instead of calculating that, so it's always correct. Also you made a pull request into your own repository, i think that might have not been intended :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed hard gauge's behavior to accurately reflect how LR2 behaves by adding additional checks for when the gauge goes below 32 and if the total is at a certain value.
The changes made are based on exch-bms2/beatoraja#628