fixes 1822 - table irregular headers example 2 code doesn't match cod…#1943
fixes 1822 - table irregular headers example 2 code doesn't match cod…#1943
Conversation
✅ Deploy Preview for wai-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks @becka11y.
It also does not apply the tutorial guidance regarding the use I've found a 2014 draft of the tutorial in CVS with this code. When the
Considering this, I'm not sure a full example code page is needed. How about removing the page and the "Full code example" link? |
|
@remibetin I'm fine with removing the full code link, but I was concerned about having a broken link in case anyone had referenced that page. I also wonder about the advice to include elements that have empty content (I'm old school when memory and bandwidth was limited; I avoid adding extra code ;). In this case, that would be the . The HTML spec does allow this. But, from an accessibility perspective, I don't see this added structure making a difference for accessibility. It seems that the thead, tbody, and tfoot provide structural relevance and are used for styling but they make no difference for screen reader announcement. The proper use of is most important for screen reader navigation of tables. The rows within are just announced as additional rows, the screen readers don't provide any announcement of the footer grouping and I didn't find any mechanisms to navigate quickly through table structure by head, body, and foot via screen readers. |
…e on main page
Resolves #1822
table irregular headers example 2 code doesn't match code on main page
Example #2 in the Tables > Irregular Headers page contains a link to the full code. This code appears to be just the snippet and the code in the main tutorial page is the full code rather than vice versa. Rather than modify/shorten the existing "snippet" on the main page and cause more confusion, I updated the example code to match this full code. The full example code link now contains the correct, full code.
I also updated the changelog since this would affect anyone who was using the example code.
@netlify /tables/irregular/