[2단계 - 영화 목록 불러오기] 피트 미션 제출합니다. #294
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { createMovieDetail, mockMovieDetails } from "../support/modalApi"; | ||
| import { createMoviePage, mockPopularMovies } from "../support/movieApi"; | ||
|
|
||
| describe("세부정보 모달 & 별점 기능 흐름", () => { | ||
| beforeEach(() => { | ||
| mockPopularMovies({ | ||
| 1: createMoviePage("인기 영화", 1), | ||
| }); | ||
|
|
||
| mockMovieDetails({ | ||
| 5: createMovieDetail(5, "인기 영화 5"), | ||
| }); | ||
|
|
||
| cy.visit("http://localhost:5173"); | ||
| cy.wait("@getPopularMovies"); | ||
| }); | ||
|
|
||
| it("영화 포스터 또는 제목을 클릭하면 세부 정보 모달을 띄울 수 있고, 별점을 매길 수 있다.", () => { | ||
|
There was a problem hiding this comment. P2; 우선 테스트 시나리오를 유저 행동 기반으로 작성한 점은 정말 좋다고 생각해요. 만약 별점을 매기기 위해 모달을 반드시 띄워야 했다면 beforEach 등으로 모달을 띄우는 과정을 기본으로 설정해둬도 좋을 것 같아요. |
||
| cy.get(".thumbnail-list li").eq(4).find(".thumbnail").click(); | ||
| cy.wait("@getMovieDetail"); | ||
|
|
||
| cy.get(".modal-background").should("have.class", "active"); | ||
| cy.get(".movie-detail h2").should("have.text", "인기 영화 5"); | ||
| cy.get(".detail").should("contain.text", "인기 영화 5 줄거리"); | ||
|
|
||
| cy.get(".rate-description").should("have.text", "별점 평가 전"); | ||
|
|
||
| cy.get('.star-container .star[value="4"]').click(); | ||
|
|
||
| cy.get(".rate-description").should("have.text", "재미있어요"); | ||
| cy.get(".rate-percentage").should("have.text", "(8/10)"); | ||
| }); | ||
|
|
||
| it("닫기 버튼 또는 ESC키를 눌러 모달을 닫을 수 있고, 새로고침해도 사용자가 매긴 별점이 유지된다.", () => { | ||
| cy.get(".thumbnail-list li").eq(4).find(".thumbnail").click(); | ||
| cy.wait("@getMovieDetail"); | ||
|
|
||
| cy.get('.star-container .star[value="4"]').click(); | ||
|
|
||
| cy.get(".close-modal").click(); | ||
| cy.get(".modal-background").should("not.have.class", "active"); | ||
|
|
||
| cy.get(".thumbnail-list li").eq(4).find(".thumbnail").click(); | ||
| cy.wait("@getMovieDetail"); | ||
|
|
||
| cy.get(".rate-description").should("have.text", "재미있어요"); | ||
| cy.get(".rate-percentage").should("have.text", "(8/10)"); | ||
|
|
||
|
Comment on lines
+34
to
+48
There was a problem hiding this comment. 테스트 시나리오 이름과 검증 내용이 불일치합니다. 케이스명은 “새로고침해도 별점 유지”인데, 본문에는 실제 🤖 Prompt for AI Agents |
||
| cy.get("body").type("{esc}"); | ||
| cy.get(".modal-background").should("not.have.class", "active"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { MockMovieDetail } from "./types"; | ||
|
|
||
| export const createMovieDetail = ( | ||
| id: number, | ||
| title: string, | ||
| ): MockMovieDetail => ({ | ||
| id, | ||
| title, | ||
| poster_path: "/test-poster.jpg", | ||
| backdrop_path: "/test-backdrop.jpg", | ||
| vote_average: 8.5, | ||
| overview: `${title} 줄거리`, | ||
| release_date: "2024-01-01", | ||
| genres: [{ name: "드라마" }], | ||
| }); | ||
|
|
||
| export const mockMovieDetails = ( | ||
| movieDetails: Record<number, MockMovieDetail>, | ||
| ) => { | ||
| cy.intercept("GET", /\/movie\/\d+\?/, (req) => { | ||
| const id = Number(req.url.split("/movie/")[1].split("?")[0]); | ||
|
|
||
| req.reply({ | ||
| statusCode: 200, | ||
| body: movieDetails[id], | ||
| }); | ||
|
Comment on lines
+20
to
+26
There was a problem hiding this comment. 누락된 상세 mock을 200 응답으로 돌려주지 않는 편이 좋습니다. 지금은 🤖 Prompt for AI Agents |
||
| }).as("getMovieDetail"); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| export type MockMovie = { | ||
|
There was a problem hiding this comment. P2; 실제 API의 응답을 MOCK 데이터로 활용할 것 같은데요. 별도의 MockMovie 타입을 만드는 이유가 있을까요? |
||
| id: number; | ||
| title: string; | ||
| poster_path: string; | ||
| backdrop_path: string; | ||
| vote_average: number; | ||
| }; | ||
|
|
||
| export type MockMovieDetail = MockMovie & { | ||
| overview: string; | ||
| release_date: string; | ||
| genres: { name: string }[]; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서 기준이 아직 버튼 방식과 무한 스크롤 방식으로 섞여 있습니다.
여기서는 무한 스크롤로 정리됐는데, 같은 README의 Line 66과 Line 72는 아직
"더 보기 버튼"기준으로 서술돼 있습니다. 요구사항과 테스트 체크리스트가 서로 다른 기준을 가리키지 않도록 한쪽으로 맞춰두는 편이 좋겠습니다.Also applies to: 74-77
🤖 Prompt for AI Agents