[2단계 - 상세 정보 & UI/UX 개선하기] 지오 미션 제출합니다. #298
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ on: | |
| branches: | ||
| - main | ||
| - step1 | ||
| - step2 | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| describe("영화 모달 테스트", () => { | ||
| beforeEach(() => { | ||
| cy.mockPopularMovies(1); | ||
| cy.getMovieDetail(83533); | ||
| cy.visit("/"); | ||
| }); | ||
|
|
||
| it("인기 있는 영화 목록이 호출이 되는지 테스트한다.", () => { | ||
| cy.wait("@getPopularMoviesPage1").its("response.body.results").should("be.an", "array"); | ||
| }); | ||
|
|
||
| it("영화 id가 83533인 영화를 클릭했을 때, 해당 영화의 상세 정보를 불러오는지 테스트한다.", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.wait("@getMovieDetail83533"); | ||
| cy.get(".modal").should("exist"); | ||
| }); | ||
|
|
||
| it("모달 안에 제목, 별점, 내용이 있는지 확인하는 테스트", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.get(".modal").should("exist"); | ||
| cy.wait("@getMovieDetail83533") | ||
| .its("response.body") | ||
| .then((movieDetail) => { | ||
| cy.get(".modal-description-title").should("contain", movieDetail.title); | ||
| cy.get("#modal-description-year").should("contain", movieDetail.release_date.split("-")[0]); | ||
| cy.get("#modal-description-genre").should("contain", movieDetail.genres.map((item: {id: Number, name: string}) => item.name).join(", ")); | ||
| cy.get("#modal-rate-number").should("contain", movieDetail.vote_average.toFixed(1)); | ||
| cy.get("#modal-detail-description").should("contain", movieDetail.overview); | ||
| }); | ||
| }); | ||
|
|
||
| it ("모달 창의 닫기 버튼을 눌렀을 때 닫히는지 테스트", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.get(".modal").should("exist"); | ||
| cy.wait("@getMovieDetail83533") | ||
| cy.get(".close-modal").click(); | ||
| cy.get(".modal-background").should("not.be.visible"); | ||
| }); | ||
|
|
||
| it ("모달 창의 ESC를 눌렀을 때 닫히는지 테스트", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.get(".modal").should("exist"); | ||
| cy.wait("@getMovieDetail83533") | ||
| cy.get("body").type('{esc}'); | ||
| cy.get(".modal-background").should("not.be.visible"); | ||
| }); | ||
| }); | ||
|
|
||
| describe("나의 평점 테스트", () => { | ||
| beforeEach(() => { | ||
| cy.mockPopularMovies(1); | ||
| cy.getMovieDetail(83533); | ||
| cy.visit("/"); | ||
| }); | ||
|
|
||
| it("별 이미지를 클릭한만큼 나의 평점 설정 가능 테스트", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.wait("@getMovieDetail83533"); | ||
| cy.get(".modal").should("exist"); | ||
| const evaluation: Record<number, string> = { | ||
| 0: "나의 별점을 눌러보세요.", | ||
| 1: "최악이예요", | ||
| 2: "별로예요", | ||
| 3: "보통이에요", | ||
| 4: "재미있어요", | ||
| 5: "명작이에요", | ||
| }; | ||
| for (let i = 1; i <= 5; i++) { | ||
| cy.get(`#my-star-image-${i}`).click(); | ||
| cy.get("#my-star-evaluation").should("contain", evaluation[i]) | ||
| cy.get("#my-star-score").should("contain", `${i * 2} / 10`); | ||
|
|
||
| for (let j = 1; j <= 5; j++) { | ||
| if (j <= i) { | ||
| cy.get(`#my-star-image-${j}`) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_filled.png") | ||
| } else { | ||
| cy.get(`#my-star-image-${j}`) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_empty.png") | ||
| } | ||
| }; | ||
| }; | ||
| }); | ||
|
|
||
| it("별 이미지를 클릭한만큼 나의 평점이 localstorage에 저장되는지 테스트", () => { | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.wait("@getMovieDetail83533"); | ||
| cy.get(".modal").should("exist"); | ||
| const evaluation: Record<number, string> = { | ||
| 0: "나의 별점을 눌러보세요.", | ||
| 1: "최악이예요", | ||
| 2: "별로예요", | ||
| 3: "보통이에요", | ||
| 4: "재미있어요", | ||
| 5: "명작이에요", | ||
| }; | ||
| for (let i = 1; i <= 5; i++) { | ||
| cy.get(`#my-star-image-${i}`).click(); | ||
| cy.get("#my-star-evaluation").should("contain", evaluation[i]) | ||
| cy.get("#my-star-score").should("contain", `${i * 2} / 10`); | ||
| cy.window().its("localStorage").invoke("getItem", 83533).should("eq", `${i * 2}`); | ||
|
|
||
| for (let j = 1; j <= 5; j++) { | ||
| if (j <= i) { | ||
| cy.get(`#my-star-image-${j}`) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_filled.png") | ||
| } else { | ||
| cy.get(`#my-star-image-${j}`) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_empty.png") | ||
| } | ||
| }; | ||
| }; | ||
| }); | ||
|
|
||
| it("local storage에 이미 평점이 있다면, 모달을 열었을 때 해당 평점이 화면에 반영되는 테스트", () => { | ||
| cy.visit("/", { | ||
| onBeforeLoad(win) { | ||
| win.localStorage.setItem("83533", "10"); | ||
| }, | ||
| }); | ||
|
|
||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.wait("@getMovieDetail83533"); | ||
|
|
||
| cy.get("#my-star-evaluation").should("contain", "명작이에요"); | ||
| cy.get("#my-star-score").should("contain", "10 / 10"); | ||
| cy.get(`#my-star-image-5`).should("have.attr", "src").and("include", "star_filled.png"); | ||
| }); | ||
| }); | ||
|
|
||
| describe("데이터 로딩 시 에러 화면을 띄우고, 다시 시도하기 버튼으로 복구하는 테스트", () => { | ||
| beforeEach(() => { | ||
| cy.mockPopularMovies(1); | ||
| cy.getMovieDetailNetworkError(83533); | ||
| cy.visit("/"); | ||
| cy.wait("@getPopularMoviesPage1"); | ||
| cy.get(`[data-movie-id=83533]`).click(); | ||
| cy.wait("@getMovieDetailNetworkError"); | ||
| }); | ||
|
|
||
| it("데이터 로딩 시 에러 화면을 띄우고, 다시 시도하기 버튼으로 복구하는 테스트", () => { | ||
| cy.get(".modal-error-container").should("not.have.class", "hidden"); | ||
| cy.get(".retry-button").should("be.visible"); | ||
|
|
||
| cy.getMovieDetail(83533); | ||
| cy.get(".retry-button").click(); | ||
|
|
||
| cy.wait("@getMovieDetail83533") | ||
| .its("response.body") | ||
| .then((movieDetail) => { | ||
| cy.get(".modal-description-title").should("contain", movieDetail.title); | ||
| cy.get("#modal-description-year").should("contain", movieDetail.release_date.split("-")[0]); | ||
| cy.get("#modal-description-genre").should("contain", movieDetail.genres.map((item: {id: Number, name: string}) => item.name).join(", ")); | ||
| cy.get("#modal-rate-number").should("contain", movieDetail.vote_average.toFixed(1)); | ||
| cy.get("#modal-detail-description").should("contain", movieDetail.overview); | ||
| }); | ||
|
|
||
| cy.get(".modal-error-container").should("have.class", "hidden"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step2푸시까지 Pages 실배포되면 안정 브랜치 결과물을 덮어쓸 수 있습니다Line 8로 인해
step2브랜치 푸시도deploy잡을 타며github-pages환경에 배포됩니다. 학습/개발 브랜치 산출물이 운영 URL에 올라갈 수 있으니, 배포는main에서만 실행되도록 제한하는 게 안전합니다.수정 예시
🤖 Prompt for AI Agents