[2단계 - 영화 목록 불러오기] 두부 미션 제출합니다. #306
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { movieDetailFixture, moviesFixture } from "../../test/fixtures"; | ||
|
|
||
| describe("영화 모달 기능 테스트", () => { | ||
| const openMovieModal = () => { | ||
| cy.get("#movie-list li").first().click(); | ||
| cy.wait("@getMovieDetail"); | ||
| cy.get("#modal-background").should("have.class", "active"); | ||
| }; | ||
|
|
||
| beforeEach(() => { | ||
| cy.intercept("GET", "**/movie/popular?page=1&language=ko-KR", { | ||
| statusCode: 200, | ||
| body: { | ||
| page: 1, | ||
| results: [...moviesFixture], | ||
| total_pages: 2, | ||
| total_results: 40, | ||
| }, | ||
| }).as("getPopularPage1"); | ||
|
|
||
| cy.intercept("GET", "**/movie/640146?language=ko-KR", { | ||
| statusCode: 200, | ||
| body: movieDetailFixture, | ||
| }).as("getMovieDetail"); | ||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Check if movie ID 640146 matches the fixture
# Expected: moviesFixture should have id: 640146 as first element
echo "=== Checking moviesFixture for movie ID ==="
rg -n "640146|id:" test/fixturesRepository: woowacourse/javascript-movie-review Length of output: 193 🏁 Script executed: #!/bin/bash
# Find fixture files in the repository
echo "=== Finding fixture files ==="
find . -name "*fixture*" -type f 2>/dev/null | head -20Repository: woowacourse/javascript-movie-review Length of output: 127 🏁 Script executed: #!/bin/bash
# Check the actual test file structure
echo "=== Checking movie-modal.cy.ts file ==="
cat -n cypress/e2e/movie-modal.cy.tsRepository: woowacourse/javascript-movie-review Length of output: 1957 🏁 Script executed: #!/bin/bash
# Search for moviesFixture and movie IDs throughout the codebase
echo "=== Searching for moviesFixture ==="
rg -n "moviesFixture" --type ts --type js | head -20Repository: woowacourse/javascript-movie-review Length of output: 1045 🏁 Script executed: #!/bin/bash
# Read the fixtures file to check the first movie's ID
echo "=== Reading test/fixtures.ts ==="
cat -n test/fixtures.ts | head -50Repository: woowacourse/javascript-movie-review Length of output: 2629 하드코딩된 영화 ID와 fixture의 연계성을 개선하세요. 현재 다음을 고려해 보세요:
🤖 Prompt for AI Agents |
||
|
|
||
| cy.visit("localhost:5173"); | ||
| cy.wait("@getPopularPage1"); | ||
| }); | ||
|
|
||
| it("영화 목록을 클릭하면 모달이 뜨고 닫기 버튼으로 닫을 수 있다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get("#close-modal").click(); | ||
| cy.get("#modal-background").should("not.have.class", "active"); | ||
| }); | ||
|
|
||
| it("ESC 버튼을 누르면 모달이 닫힌다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get("body").type("{esc}"); | ||
| cy.get("#modal-background").should("not.have.class", "active"); | ||
| }); | ||
|
|
||
| it("모달창이 아닌 부분을 클릭하면 모달이 닫힌다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get("#modal-background").click("topLeft"); | ||
| cy.get("#modal-background").should("not.have.class", "active"); | ||
| }); | ||
|
|
||
| it("모달창이 뜨면 배경 스크롤이 적용되지 않는다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get("body").should("have.class", "modal-open"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { movieDetailFixture, moviesFixture } from "../../test/fixtures"; | ||
| import { RATING_SCORES, RATING_TEXTS } from "../../src/constants/rating"; | ||
|
|
||
| describe("영화 별점 기능 테스트", () => { | ||
| const openMovieModal = () => { | ||
| cy.get("#movie-list li").first().click(); | ||
| cy.wait("@getMovieDetail"); | ||
| cy.get("#modal-background").should("have.class", "active"); | ||
| }; | ||
|
|
||
| beforeEach(() => { | ||
| cy.intercept("GET", "**/movie/popular?page=1&language=ko-KR", { | ||
| statusCode: 200, | ||
| body: { | ||
| page: 1, | ||
| results: [...moviesFixture], | ||
| total_pages: 2, | ||
| total_results: 40, | ||
| }, | ||
| }).as("getPopularPage1"); | ||
|
|
||
| cy.intercept("GET", "**/movie/640146?language=ko-KR", { | ||
| statusCode: 200, | ||
| body: movieDetailFixture, | ||
| }).as("getMovieDetail"); | ||
|
|
||
| cy.visit("localhost:5173"); | ||
| cy.wait("@getPopularPage1"); | ||
| cy.clearLocalStorage(); | ||
| }); | ||
|
|
||
| it("모달창에서 별점을 클릭하면 해당 별만큼 채워지고 점수와 평가 문구가 바뀐다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get(".movie-rating .stars img").eq(3).click(); | ||
|
|
||
| cy.get(".movie-rating .stars img") | ||
| .eq(0) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_filled.png"); | ||
|
|
||
| cy.get(".movie-rating .stars img") | ||
| .eq(3) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_filled.png"); | ||
|
|
||
| cy.get(".movie-rating .stars img") | ||
| .eq(4) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_empty.png"); | ||
|
|
||
| cy.get(".rating-text").should("have.text", RATING_TEXTS[3]); | ||
| cy.get("#rating-value").should("have.text", RATING_SCORES[3]); | ||
| }); | ||
|
|
||
| it("별점을 매기고 다시 모달을 열면 이전 별점이 유지된다", () => { | ||
| openMovieModal(); | ||
|
|
||
| cy.get(".movie-rating .stars img").eq(3).click(); | ||
| cy.get("#close-modal").click(); | ||
|
|
||
| openMovieModal(); | ||
|
|
||
| cy.get(".rating-text").should("have.text", RATING_TEXTS[3]); | ||
| cy.get("#rating-value").should("have.text", RATING_SCORES[3]); | ||
|
|
||
| cy.get(".movie-rating .stars img") | ||
| .eq(3) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_filled.png"); | ||
|
|
||
| cy.get(".movie-rating .stars img") | ||
| .eq(4) | ||
| .should("have.attr", "src") | ||
| .and("include", "star_empty.png"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
movie-rating.cy.ts 도 동일한 openMovieModal() 헬퍼를 각각 정의하고 있는데요. 공통유틸로 분리해보면 어떨까요?