Skip to content

Masterbar Item: Do not pass component-specific prop to HTML elements#109945

Open
zaguiini wants to merge 1 commit intotrunkfrom
fix/masterbar-unknown-is-busy-prop
Open

Masterbar Item: Do not pass component-specific prop to HTML elements#109945
zaguiini wants to merge 1 commit intotrunkfrom
fix/masterbar-unknown-is-busy-prop

Conversation

@zaguiini
Copy link
Copy Markdown
Contributor

Fixes #109896 (comment).

Proposed Changes

Adds an extra asProps prop that is only filled if the user is passing a custom component through the as prop.

Testing Instructions

Enter /home/%s where %s is a site that has never been launched.

  • Verify you don't see the console warning anymore.
  • Verify you see the launch button.
  • Verify you can click the launch button and the loading state still applies.

@zaguiini zaguiini self-assigned this Apr 10, 2026
@zaguiini zaguiini requested review from a team April 10, 2026 14:56
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 10, 2026
@matticbot
Copy link
Copy Markdown
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/masterbar-unknown-is-busy-prop on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants