Skip to content

feat(CLI)!: adopt ESM for blocks and themes #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ragi96 merged 3 commits into from
Mar 31, 2026

Merge branch 'dev' into feat/esm-block-theme

4fced25
Select commit
Loading
Failed to load commit list.
Merged

feat(CLI)!: adopt ESM for blocks and themes #1482

Merge branch 'dev' into feat/esm-block-theme
4fced25
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / [CLI] SonarCloud Code Analysis failed Mar 31, 2026 in 38s

Quality Gate failed

Failed conditions
9.5% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 38 in packages/cli/src/utils/vitePlugins.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VmIpZiw5iipWGe&open=AZ0Gq9VmIpZiw5iipWGe&pullRequest=1482

Check warning on line 55 in packages/cli/src/utils/vitePlugins.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VmIpZiw5iipWGg&open=AZ0Gq9VmIpZiw5iipWGg&pullRequest=1482

Check warning on line 45 in packages/cli/src/utils/vitePlugins.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VmIpZiw5iipWGf&open=AZ0Gq9VmIpZiw5iipWGf&pullRequest=1482

Check warning on line 65 in packages/cli/src/servers/blockDevelopmentServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9V6IpZiw5iipWGi&open=AZ0Gq9V6IpZiw5iipWGi&pullRequest=1482

Check warning on line 65 in packages/cli/src/servers/themeDevelopmentServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VyIpZiw5iipWGh&open=AZ0Gq9VyIpZiw5iipWGh&pullRequest=1482

Check warning on line 31 in packages/cli/src/utils/compiler/compileTheme.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9RdIpZiw5iipWGb&open=AZ0Gq9RdIpZiw5iipWGb&pullRequest=1482

Check warning on line 31 in packages/cli/src/utils/compiler/compileBlock.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VeIpZiw5iipWGc&open=AZ0Gq9VeIpZiw5iipWGc&pullRequest=1482

Check warning on line 25 in packages/cli/src/utils/vitePlugins.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [CLI] SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=frontify_brand-sdk_cli&issues=AZ0Gq9VmIpZiw5iipWGd&open=AZ0Gq9VmIpZiw5iipWGd&pullRequest=1482
View more details on SonarQubeCloud