Disable extreme distribution tests that is failing in CI#8324
Merged
davebayer merged 2 commits intoNVIDIA:mainfrom Apr 9, 2026
Merged
Disable extreme distribution tests that is failing in CI#8324davebayer merged 2 commits intoNVIDIA:mainfrom
davebayer merged 2 commits intoNVIDIA:mainfrom
Conversation
I could reproduce failures locally on blackwell devices Fixes nvbug6007539
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 41m: Pass: 100%/65 | Total: 11h 29m | Max: 1h 35m | Hits: 98%/257290See results here. |
Collaborator
Does that not concern us? |
miscco
commented
Apr 9, 2026
| auto dist_val = d1(g_1, param); | ||
| auto dist2_val = d2(g_2); | ||
| assert(dist_val == dist2_val); | ||
| assert((dist_val == dist2_val) || (cuda::std::isnan(dist_val) && cuda::std::isnan(dist2_val))); |
Contributor
Author
There was a problem hiding this comment.
@jrhemstad I investigated with @RAMitchell and it turns out that the extreme value distribution generates NaN on device, which compare unequal
davebayer
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could reproduce failures locally on blackwell devices
Fixes nvbug6007539