Skip to content

Disable extreme distribution tests that is failing in CI #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davebayer merged 2 commits into from
Apr 9, 2026
+3 −1
Merged

Disable extreme distribution tests that is failing in CI #8324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea4534
Disable extreme distribution tests that is failing in CI
miscco Apr 8, 2026
f70d977
Avoid NaN comparisons on device
miscco Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libcudacxx/test/libcudacxx/std/random/distribution/extreme_value.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
// template<class RealType = double>
// class extreme_value_distribution

// UNSUPPORTED: true

#include <cuda/std/cassert>
#include <cuda/std/cmath>
#include <cuda/std/random>
Expand Down
2 changes: 1 addition & 1 deletion libcudacxx/test/support/random_utilities/test_distribution.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ __host__ __device__ bool test_eval(const typename D::param_type param, CDF cdf)
{
auto dist_val = d1(g_1, param);
auto dist2_val = d2(g_2);
assert(dist_val == dist2_val);
assert((dist_val == dist2_val) || (cuda::std::isnan(dist_val) && cuda::std::isnan(dist2_val)));
Copy link
Copy Markdown
Contributor Author

@miscco miscco Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhemstad I investigated with @RAMitchell and it turns out that the extreme value distribution generates NaN on device, which compare unequal

}
}

Expand Down
Loading