Updated monolithic demo readme to mention precompiled drake-visualizer by naveenoid · Pull Request #6362 · RobotLocomotion/drake

naveenoid · 2017-06-16T19:46:36Z

Addresses #6354

This change is

naveenoid · 2017-06-16T19:48:13Z

+@RussTedrake for feature and platform review. (Its a straightforward fix).

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

RussTedrake · 2017-06-16T22:16:35Z

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 19 at r1 (raw file):

$ cd drake-distro
$ bazel build //tools:drake_visualizer && bazel-build //drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place:monolithic_pick_and_place_demo

bazel-build?

perhaps just
bazel build //tools:drake_visualizer //drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place:monolithic_pick_and_place_demo

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 28 at r1 (raw file):

$ bazel-bin/tools/drake-visualizer&

that doesn't work for me (on mac)

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 36 at r1 (raw file):

$ ./bazel-bin/drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/

or should we prefer recommending bazel run?

Comments from Reviewable

jwnimmer-tri · 2017-06-16T22:30:28Z

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 28 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

that doesn't work for me (on mac)

FYI Mac still lacks some version of the #6319 fix that happened on linux.

Comments from Reviewable

naveenoid · 2017-06-26T19:27:11Z

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 19 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

bazel-build?

perhaps just
bazel build //tools:drake_visualizer //drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place:monolithic_pick_and_place_demo

Done.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 28 at r1 (raw file):

#6319
Added a comment about it not working on mac.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 36 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

or should we prefer recommending bazel run?

Done. Swapped the recommendations.

Comments from Reviewable

RussTedrake · 2017-06-27T11:45:03Z

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 19 at r1 (raw file):

Previously, naveenoid (Naveen Kuppuswamy) wrote…

Done.

not done? you don't need the && bazel build ... bazel can take multiple targets as multiple arguments.

Comments from Reviewable

naveenoid · 2017-06-29T14:48:32Z

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 19 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

not done? you don't need the && bazel build ... bazel can take multiple targets as multiple arguments.

Done.

Comments from Reviewable

RussTedrake · 2017-06-29T18:18:48Z

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

naveenoid · 2017-06-29T18:45:59Z

+@soonho-tri for platform review.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

soonho-tri · 2017-06-29T19:22:23Z

@drake-jenkins-bot linux-xenial-clang-ninja-experimental-open-source please

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

soonho-tri · 2017-06-29T20:05:27Z

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 28 at r2 (raw file):

bazel-bin/tools/drake-visualizer

It should be drake-visualizer => drake_visualizer.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 42 at r2 (raw file):

bazel run :monolithic_pick_and_place_demo --config snopt -- --box_choice=1

Is --box_choice option still valid? I've rebased this PR over the current master and follow the instructions, but I get:

ERROR: unknown command line flag 'box_choice'

Comments from Reviewable

soonho-tri · 2017-06-29T20:05:30Z

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

jwnimmer-tri · 2017-06-29T20:08:53Z

This is in dev, you don't need platform review, eh?

naveenoid · 2017-06-29T20:26:48Z

Right! But good catch by soonho anyways. I will wait for his LGTM nonetheless.

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 28 at r2 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

bazel-bin/tools/drake-visualizer

It should be drake-visualizer => drake_visualizer.

Done.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 42 at r2 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

Is --box_choice option still valid? I've rebased this PR over the current master and follow the instructions, but I get:
ERROR: unknown command line flag 'box_choice'

Done.

Comments from Reviewable

soonho-tri · 2017-06-29T20:31:17Z

(aside a BTW)

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 55 at r3 (raw file):

Command line arguments can be passed for : box_choice an integer between 1

BTW, we still have box_choice here.

Comments from Reviewable

soonho-tri · 2017-06-29T20:31:21Z

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

naveenoid · 2017-06-29T20:40:55Z

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

drake/examples/kuka_iiwa_arm/dev/monolithic_pick_and_place/README.md, line 55 at r3 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

BTW, we still have box_choice here.

Done.

Comments from Reviewable

soonho-tri · 2017-06-29T23:52:23Z

@drake-jenkins-bot linux-xenial-clang-ninja-experimental-open-source please

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

soonho-tri · 2017-06-29T23:53:04Z

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

fix ready

99473eb

naveenoid requested a review from RussTedrake June 16, 2017 19:47

naveenoid assigned RussTedrake Jun 16, 2017

naveenoid added 3 commits June 19, 2017 16:11

WIP

a21bf70

reviewer comments addressed

2feb1b8

readme modified

f067856

review comments addressed

cd4d829

naveenoid force-pushed the pr/monolithic_demo_README_fix branch from b1e4282 to cd4d829 Compare June 26, 2017 19:32

bazel build fix

dd738a4

RussTedrake added the status: curate commits before merging label Jun 29, 2017

naveenoid assigned soonho-tri Jun 29, 2017

naveenoid added 2 commits June 29, 2017 16:24

box_choice --> target

7b3dd08

drake_visualizer

97e803a

Doh

96bcc65

soonho-tri removed the status: curate commits before merging label Jun 30, 2017

soonho-tri merged commit 421382f into RobotLocomotion:master Jun 30, 2017

naveenoid deleted the pr/monolithic_demo_README_fix branch September 3, 2018 01:44

Conversation

naveenoid commented Jun 16, 2017 • edited by sherm1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

naveenoid commented Jun 16, 2017

Uh oh!

RussTedrake commented Jun 16, 2017

Uh oh!

jwnimmer-tri commented Jun 16, 2017

Uh oh!

naveenoid commented Jun 26, 2017

Uh oh!

RussTedrake commented Jun 27, 2017

Uh oh!

naveenoid commented Jun 29, 2017

Uh oh!

RussTedrake commented Jun 29, 2017

Uh oh!

naveenoid commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

jwnimmer-tri commented Jun 29, 2017

Uh oh!

naveenoid commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

naveenoid commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

soonho-tri commented Jun 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

naveenoid commented Jun 16, 2017 •

edited by sherm1

Loading