Image block: Hide drag handles while an upload is in progress#77121
Open
andrewserong wants to merge 3 commits intotrunkfrom
Open
Image block: Hide drag handles while an upload is in progress#77121andrewserong wants to merge 3 commits intotrunkfrom
andrewserong wants to merge 3 commits intotrunkfrom
Conversation
andrewserong
requested review from
aaronrobertshaw,
adamsilverstein,
ramonjd,
talldan and
tellthemachines
andrewserong
added
the
[Type] Bug
andrewserong
added
the
[Feature] Media
andrewserong
added
[Block] Image
ramonjd
reviewed
Apr 8, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Apr 8, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Agree, much tidier!
Kapture.2026-04-08.at.16.14.32.mp4
Also checked with HEIC!
|
Size Change: +34 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for the quick review! 🙇 |
|
Flaky tests detected in 7285744. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24121294916
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Hide the drag handles on an image block while an upload is in progress.
Why?
While you can technically interact with the block while the upload is in progress, the drag handles in this state aren't particularly useful.
Additionally, if a user is uploading an HEIC file, then (currently) using the server-side upload approach, the image isn't previewable in the editor during upload and the resize handles can display in the wrong place.
It's tidier all around if we hide the drag handles while an upload is in progress.
How?
Add some simple conditions to ensure the drag handles are not visible if the image is a temporary URL (i.e. an upload is in progress), or the sub-size images are being sideloaded.
Testing Instructions
On trunk:
With this PR:
Screenshots or screencast
Before (JPEG)
2026-04-08.15.44.12.mp4
After (JPEG)
2026-04-08.15.44.38.mp4
Before (HEIC)
2026-04-08.15.49.02.mp4
After (HEIC)
2026-04-08.15.47.52.mp4
Use of AI Tools
Claude Code to generate the code change. Tested manually and wrote the PR description myself 😄