Skip to content

Image block: Hide drag handles while an upload is in progress #77121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 3 commits into from
Apr 8, 2026
Merged

Image block: Hide drag handles while an upload is in progress #77121

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
025ce83
Image block: Hide drag handles while an upload is in progress
andrewserong Apr 8, 2026
d00bb9b
Move the isUploading check further up for consistency
andrewserong Apr 8, 2026
7285744
Replace another double check with a single check
andrewserong Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ export default function Image( {
hasNonContentControls &&
! isWideAligned &&
isLargeViewport;
// An image is uploading if it has a temporary blob URL, or if it is
// being processed client-side (e.g. transcoded or generating sub-sizes).
const isUploading = !! temporaryURL || isSideloading;
const imageSizeOptions = imageSizes
.filter(
( { slug } ) => image?.media_details?.sizes?.[ slug ]?.source_url
Expand Down Expand Up @@ -885,9 +888,7 @@ export default function Image( {
onSelectURL={ onSelectURL }
onError={ onUploadError }
onReset={ () => onSelectImage( undefined ) }
isUploading={
!! temporaryURL || isSideloading
}
isUploading={ isUploading }
emptyLabel={ __( 'Add image' ) }
/>
</ToolsPanelItem>
Expand Down Expand Up @@ -1078,7 +1079,7 @@ export default function Image( {
...shadowProps.style,
} }
/>
{ ( temporaryURL || isSideloading ) && <Spinner /> }
{ isUploading && <Spinner /> }
</>
);

Expand Down Expand Up @@ -1110,6 +1111,7 @@ export default function Image( {
isResizable &&
isSingleSelected &&
! isEditingImage &&
! isUploading &&
! SIZED_LAYOUTS.includes( parentLayoutType )
) {
const numericRatio = aspectRatio && evalAspectRatio( aspectRatio );
Expand Down
Loading