Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +498 B (+0.01%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in c307e8d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24232661595
|
oandregal
approved these changes
Apr 10, 2026
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #77132
Updates
FormToggledisabled styles so the checked disabled state no longer relies on a blanket opacity reduction.Why?
The previous disabled treatment dimmed the entire control with
opacity: 0.3, which is not themable, and keeping the accent color active in a disabled state is not the direction we're heading with the new design system.This brings
FormTogglecloser to the newer disabled styling direction used forCheckboxControlin #77132, and thus closer to the new design system styles we want.How?
Replaces the disabled opacity rule with explicit disabled track and thumb colors.
Also adds
forced-colorsadjustments so the disabled checked track and thumb still render with the intended system colors in Windows High Contrast Mode.Testing Instructions
npm run storybook:dev.Components / FormToggle.forced-colorsmode in dev tools and confirm the disabled checked track and thumb still render with the expected system colors.Screenshots or screencast
Forced colors mode
Use of AI Tools
Drafted with AI assistance and reviewed before submission.