[GLUTEN-11888] [VL] Remove the synchronized lock in VeloxBroadcastBuildSideCache#11834
Merged
JkSelf merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
[GLUTEN-11888] [VL] Remove the synchronized lock in VeloxBroadcastBuildSideCache#11834JkSelf merged 1 commit intoapache:mainfrom
JkSelf merged 1 commit intoapache:mainfrom
Conversation
JkSelf
force-pushed
the
remove-bhj-lock
branch
3 times, most recently
from
328eba1 to
35de5e3
Compare
JkSelf
changed the title
jinchengchenghh
approved these changes
Apr 8, 2026
Contributor
|
Could you describe the existing synchronized mechanism in PR description? |
malinjawi
pushed a commit
to malinjawi/incubator-gluten
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
VeloxBroadcastBuildSideCache is managed by Caffe, which is already thread-safe. So we don't need to add manual synchronization.
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
no
Related issue: #11888