Skip to content

[GLUTEN-11888] [VL] Remove the synchronized lock in VeloxBroadcastBuildSideCache #11834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JkSelf merged 1 commit into from
Apr 8, 2026
+7 −8
Merged

[GLUTEN-11888] [VL] Remove the synchronized lock in VeloxBroadcastBuildSideCache #11834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ object VeloxBroadcastBuildSideCache

def getOrBuildBroadcastHashTable(
broadcast: Broadcast[BuildSideRelation],
broadcastContext: BroadcastHashJoinContext): BroadcastHashTable = synchronized {
broadcastContext: BroadcastHashJoinContext): BroadcastHashTable = {

buildSideRelationCache
.get(
Expand All @@ -76,14 +76,13 @@ object VeloxBroadcastBuildSideCache
}

/** This is callback from c++ backend. */
def get(broadcastHashtableId: String): Long =
synchronized {
Option(buildSideRelationCache.getIfPresent(broadcastHashtableId))
.map(_.pointer)
.getOrElse(0)
}
def get(broadcastHashtableId: String): Long = {
Option(buildSideRelationCache.getIfPresent(broadcastHashtableId))
.map(_.pointer)
.getOrElse(0)
}

def invalidateBroadcastHashtable(broadcastHashtableId: String): Unit = synchronized {
def invalidateBroadcastHashtable(broadcastHashtableId: String): Unit = {
// Cleanup operations on the backend are idempotent.
buildSideRelationCache.invalidate(broadcastHashtableId)
}
Expand Down
Loading