Skip to content

Remove restartPolicy duplication#278

Open
nekwar wants to merge 5 commits intoappvia:masterfrom
nekwar:master
Open

Remove restartPolicy duplication#278
nekwar wants to merge 5 commits intoappvia:masterfrom
nekwar:master

Conversation

@nekwar
Copy link
Copy Markdown

@nekwar nekwar commented Nov 23, 2022

Remove restartPolicy duplication for redisgraph container in helm templates

@nekwar
Copy link
Copy Markdown
Author

nekwar commented Nov 23, 2022

Related issue: #277

@marcinc marcinc self-requested a review November 29, 2022 17:11
Copy link
Copy Markdown
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @nekwar. Left a couple of small comments.

appVersion: "v0.1.2"
sources:
- https://github.com/appvia/krane
- https://github.com/nekwar/krane
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be reverted.

version: 0.1.1
appVersion: "v0.1.1"
version: 0.1.2
appVersion: "v0.1.2"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the v0.1.1 for now. As soon as new release goes out I'll make sure to bump it up. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants