Skip to content

Remove restartPolicy duplication #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nekwar wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove restartPolicy duplication #278

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0653bbf
Remove restartPolicy duplication
nekwar Nov 23, 2022
6a718b3
Update Chart.yaml
nekwar Nov 25, 2022
f36cd40
Remove duplicated labels
nekwar Nov 25, 2022
f3d10fb
Update Chart.yaml
nekwar Nov 25, 2022
da62c7a
Merge branch 'master' into master
marcinc Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/krane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ apiVersion: v2
name: krane
description: A Helm chart for Krane
type: application
version: 0.1.1
appVersion: "v0.1.1"
version: 0.1.2
appVersion: "v0.1.2"
Copy link
Copy Markdown
Member

@marcinc marcinc Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the v0.1.1 for now. As soon as new release goes out I'll make sure to bump it up. Thanks.

sources:
- https://github.com/appvia/krane
- https://github.com/nekwar/krane
Copy link
Copy Markdown
Member

@marcinc marcinc Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be reverted.

maintainers:
- name: Appvia
email: info@appvia.io
Expand Down
2 changes: 0 additions & 2 deletions charts/krane/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
restartPolicy: Always

# Krane
---
Expand All @@ -70,7 +69,6 @@ metadata:
labels:
{{- include "krane.labels" . | nindent 4 }}
{{- include "krane.selectorLabels" . | nindent 4 }}
network/krane: "true"
spec:
replicas: 1
selector:
Expand Down