Add Process.capture#16773
Merged
straight-shoota merged 11 commits intocrystal-lang:masterfrom Mar 28, 2026
Merged
Conversation
This was referenced Mar 23, 2026
6a3737c to
d5de6ab
Compare
5a8c7fe to
f8c3d2a
Compare
Member
Author
|
This interpreter failure is pretty bizarre:
|
Closed
ysbaddaden
reviewed
Mar 24, 2026
ysbaddaden
approved these changes
Mar 24, 2026
Collaborator
|
I'm having second thoughts on |
Member
Author
|
Yeah, these methods are all essentially convenience wrappers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
Process.capture,Process.capture?andProcess.capture_resultfrom RFC 0025.This implements the basic capture behaviour, which may be enhanced in the future.
In particular, this patch misses truncation of the captured error stream which will be a follow-up (#16774).
Resolves #7171