Add IO::PrefixSuffixBuffer for capturing truncated streams#16774
Open
straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
Open
Add IO::PrefixSuffixBuffer for capturing truncated streams#16774straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
IO::PrefixSuffixBuffer for capturing truncated streams#16774straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
Conversation
This was referenced Mar 23, 2026
Merged
straight-shoota
force-pushed
the
feat/prefix-suffix-buffer
branch
from
673dc45 to
228d526
Compare
ysbaddaden
reviewed
Mar 24, 2026
straight-shoota
added a commit
that referenced
this pull request
Mar 28, 2026
Implement `Process.capture`, `Process.capture?` and `Process.capture_result` from [RFC 0025](crystal-lang/rfcs#25). This implements the basic capture behaviour, which may be enhanced in the future. In particular, this patch misses truncation of the captured error stream which will be a follow-up (#16774).
straight-shoota
force-pushed
the
feat/prefix-suffix-buffer
branch
from
228d526 to
8b6e8f2
Compare
Member
Author
|
The failure on Windows is a bit suprising because the buffer implementation should be entirely identical across platforms. But the reason appears to be different chunking sizes when piping the stream on Windows. The failure reproduces on Linux with the same chunk sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements truncated error stream capture from RFC 0025.
Depends on #16773